lkml.org 
[lkml]   [2015]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs
On Wed, 22 Jul 2015, Dmitry Torokhov wrote:

> Yes, I'll change how we count the leds to skip unnamed, then the patch
> below won't be needed.

Agreed.

> BTW, maybe we should be using hid_map_usage_clear() in map_led() as it
> does not make much sense to convert CAPS LOCK into SCROLL LOCK in case
> keyboard happens to have 2 usages for caps...

Indeed, makes sense generally for all LEDs I think.

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2015-07-23 00:21    [W:0.050 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site