lkml.org 
[lkml]   [2015]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs
On Wed, 22 Jul 2015, Pavel Machek wrote:

> > I am however not sure whether input_leds_connect() is not too unkind to
> > unnamed LEDs and shouldn't be more tolerant to those in the long term.
>
> Maybe.
>
> > From: Jiri Kosina <jkosina@suse.com>
> > Subject: [PATCH] Input: leds: don't attempt to deregister unnamed LEDs
> >
> > input_leds_connect() is skipping registration of LEDs for which
> > there is no symbolic name in input_led_info[].
>
> Yes, and rather than testing for "no name" special case at two places,
> what about simply giving up when we see such error?

Well, that's quite the oposite of the "be more tolerant" aproach proposed
above :)

I don't see a reason why the sole fact that the device has at least one
LED that kernel can't handle properly should mean that neither of the
other LEDs will work.

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2015-07-23 00:21    [W:0.932 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site