lkml.org 
[lkml]   [2015]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] RTC: switch to using is_visible() to control sysfs attributes
Hi,

Seems mostly good, a few comments on top of Krzysztof's below:

On 20/07/2015 at 16:02:52 -0700, Dmitry Torokhov wrote :
> Instead of creating an attribute manually, after the device has been
> registered, let's rely on facilities provided by the attribute groups to
> control which attributes are visible and which are not. This allows to to
too many 'to' here --------------------------------------------------^

[...]

> -void __init rtc_sysfs_init(struct class *rtc_class)
> +const struct attribute_group** rtc_get_dev_attribute_groups(void)
That space is not properly placed ^, this should be:
const struct attribute_group **rtc_get_dev_attribute_groups(void)


--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


\
 
 \ /
  Last update: 2015-07-22 23:21    [W:0.087 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site