lkml.org 
[lkml]   [2015]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [rtc-linux] [PATCH 1/4] RTC: fix double free in rtc_register_device() error path
From
On Mon, Jul 20, 2015 at 5:32 PM, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
> 2015-07-21 8:02 GMT+09:00 Dmitry Torokhov <dmitry.torokhov@gmail.com>:
>> Commit 59cca865f21e9e7beab73fcf79ba4eb776a4c228 correctly noted that naked
>> kfree() should not be used after failed device_register() call, however,
>> while it added the needed put_device() it forgot to remove the original
>> kfree() causing double-free.
>>
>> Cc: Vasiliy Kulikov <segooon@gmail.com>
>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>> ---
>> drivers/rtc/class.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> I think it can be cc'ed stable (with fixes tag).

I considered that, but it does not happen on normally working systems.
I'll leave it up to maintainers to annotate as they see fit.

Thanks.

--
Dmitry


\
 
 \ /
  Last update: 2015-07-21 03:01    [W:0.221 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site