Messages in this thread | | | From | Andy Lutomirski <> | Date | Mon, 20 Jul 2015 23:30:47 -0700 | Subject | Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct |
| |
On Mon, Jul 20, 2015 at 11:28 PM, Ingo Molnar <mingo@kernel.org> wrote: > > * Brian Gerst <brgerst@gmail.com> wrote: > >> Allocate a separate structure for the vm86 fields. > > Why is this allocated dynamically? This structure is not very large, and a hole in > thread_struct isn't that big of an issue - compared to additional fragility > introduced by the (mostly untested by normal apps) dynamic allocation here ... > > I don't mind the introduction of the sub-structure in itself, but please embedd it > in thread_struct. >
This ends up being several hundred bytes, I think, due to including an entire struct pt_regs. Do we really want to enlarge thread_struct that much for something that's essentially never used?
--Andy
| |