lkml.org 
[lkml]   [2015]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[tip:perf/core] perf strlist: load() should return a negative errno
Commit-ID:  ab7322af8c620987ed058e39506c97e5f2d3c65c
Gitweb: http://git.kernel.org/tip/ab7322af8c620987ed058e39506c97e5f2d3c65c
Author: Arnaldo Carvalho de Melo <acme@redhat.com>
AuthorDate: Thu, 16 Jul 2015 11:08:34 -0300
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 16 Jul 2015 11:08:34 -0300

perf strlist: load() should return a negative errno

To match what its users return.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-jntpe2lwg1fxn1bku7uccan0@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/strlist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/strlist.c b/tools/perf/util/strlist.c
index 71f9d10..68ae673 100644
--- a/tools/perf/util/strlist.c
+++ b/tools/perf/util/strlist.c
@@ -72,7 +72,7 @@ int strlist__load(struct strlist *slist, const char *filename)
FILE *fp = fopen(filename, "r");

if (fp == NULL)
- return errno;
+ return -errno;

while (fgets(entry, sizeof(entry), fp) != NULL) {
const size_t len = strlen(entry);

\
 
 \ /
  Last update: 2015-07-21 11:41    [W:0.068 / U:1.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site