Messages in this thread | | | Date | Thu, 2 Jul 2015 13:04:07 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH v7 1/3] sysfs: added sysfs_link_entry_to_kobj() |
| |
Hello, Jason.
On Tue, Jun 23, 2015 at 10:19:32AM -0600, Jason Gunthorpe wrote: > The concept was to move the sysfs files to the natural location on the > core's struct tpm.struct device and leave a symlink behind on the > platform_device for compat.
I see. The only problem I see is that this might get abused. Can you clearly mark the function that it's not intended to be used in anything new, e.g. by renaming it to sth like __compat_only_sysfs_link_entry_to_kobj().
> We could also just move the sysfs file and ignore the compat symlink, > but it is not clear to me if that is an OK UAPI break for sysfs?
We shouldn't if it has actual chance of disturbing userland.
Thanks.
-- tejun
| |