Messages in this thread | | | Date | Mon, 22 Jun 2015 14:01:54 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH v7 1/3] sysfs: added sysfs_link_entry_to_kobj() |
| |
On Mon, Jun 22, 2015 at 11:52:53AM -0600, Jason Gunthorpe wrote: > On Mon, Jun 22, 2015 at 01:30:39PM -0400, Tejun Heo wrote: > > On Mon, Jun 22, 2015 at 08:24:50PM +0300, Jarkko Sakkinen wrote: > > > Added a new function sysfs_link_group_to_kobj() that adds a symlink > > > from attribute or group to a kobject. Exported kernfs_remove_by_name_ns > > > in order to provide a way to remove such symlinks. > > > > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > > > > Hmmm... is this *really* necessary? If linking from the parent kobj > > doesn't make a fundamental functional difference, I don't think this > > is a good idea. If linking to the parent doesn't work, why doesn't > > it? Shouldn't that already be a different kobj then? I'd really like > > to keep groups as a dumb container of simple attrs. > > TPM is undergoing a migration of core attributes from the > platform_device to the core's struct device. > > The only purpose of the symlink was to provide userspace > compatability with the old location.
Ah, yeah, that's painful. Can you please briefly explain why it wasn't necessary before? Are you merging multiple devices into one?
Thanks.
-- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
| |