Messages in this thread Patch in this message | | | From | Masahiro Yamada <> | Subject | [PATCH v2] devres: fix devres_get() | Date | Wed, 15 Jul 2015 10:29:00 +0900 |
| |
Currently, devres_get() passes devres_free() the pointer to devres, but devres_free() should be given with the pointer to resource data.
Fixes: 9ac7849e35f7 ("devres: device resource management") Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Acked-by: Tejun Heo <tj@kernel.org> ---
Changes in v2: - Fix "Fixes: " tag format ("Fixes: commit ... -> Fixes: ...) - Add Tejun's Acked-by - Cc stable@vger.kernel.org
drivers/base/devres.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/devres.c b/drivers/base/devres.c index c8a53d1..8754646 100644 --- a/drivers/base/devres.c +++ b/drivers/base/devres.c @@ -297,10 +297,10 @@ void * devres_get(struct device *dev, void *new_res, if (!dr) { add_dr(dev, &new_dr->node); dr = new_dr; - new_dr = NULL; + new_res = NULL; } spin_unlock_irqrestore(&dev->devres_lock, flags); - devres_free(new_dr); + devres_free(new_res); return dr->data; } -- 1.9.1
| |