Messages in this thread | | | Date | Wed, 15 Jul 2015 09:27:43 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH V2] checkpatch: Add some <foo>_destroy functions to NEEDLESS_IF tests |
| |
On (07/14/15 16:03), Andrew Morton wrote: > > Sergey Senozhatsky has modified several destroy functions that can > > now be called with NULL values. > > > > - kmem_cache_destroy() > > - mempool_destroy() > > - dma_pool_destroy() > > > > Update checkpatch to warn when those functions are preceded by an if. > > > > Update checkpatch to --fix all the calls too only when the code style > > form is using leading tabs. > > > > from: > > if (foo) > > <func>(foo); > > to: > > <func>(foo); > > There's also zpool_destroy_pool() and zs_destroy_pool(). Did we decide > they're not worth bothering about?
Correct. Those two are very unlikely will see any significant number of users so, I think, we can drop the patches that touch zspool and zsmalloc destructors.
-ss
| |