lkml.org 
[lkml]   [2015]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] checkpatch: Add some <foo>_destroy functions to NEEDLESS_IF tests
On Tue, 09 Jun 2015 22:52:29 -0700 Joe Perches <joe@perches.com> wrote:

> Sergey Senozhatsky has modified several destroy functions that can
> now be called with NULL values.
>
> - kmem_cache_destroy()
> - mempool_destroy()
> - dma_pool_destroy()
>
> Update checkpatch to warn when those functions are preceded by an if.
>
> Update checkpatch to --fix all the calls too only when the code style
> form is using leading tabs.
>
> from:
> if (foo)
> <func>(foo);
> to:
> <func>(foo);

There's also zpool_destroy_pool() and zs_destroy_pool(). Did we decide
they're not worth bothering about?




\
 
 \ /
  Last update: 2015-07-15 01:21    [W:0.090 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site