lkml.org 
[lkml]   [2015]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue
On Wed, Jul 01, 2015 at 01:06:48PM +0530, Sohny Thomas wrote:
<snip>
> >No, now this will introduce a new checkpatch warning that "else is not
> >required after return". why did you introduce this "else"?
> I did this so that the code is more readable and understandable, I
> checked and checkpatch didn't call this out , so its clean.
>
> Otherwise the above code looks like this
>
> if(i)
> return 1;
> return 0;
you should update your tree. virtpci folder has been deleted from
unisys driver.
As you are using an old tree, maybe that explains why checkpatch is not
giving the error.

regards
sudip


\
 
 \ /
  Last update: 2015-07-01 10:21    [W:0.120 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site