lkml.org 
[lkml]   [2015]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue
    From
    Date


    On Wednesday 01 July 2015 01:32 PM, Sudip Mukherjee wrote:
    > On Wed, Jul 01, 2015 at 01:06:48PM +0530, Sohny Thomas wrote:
    > <snip>
    >>> No, now this will introduce a new checkpatch warning that "else is not
    >>> required after return". why did you introduce this "else"?
    >> I did this so that the code is more readable and understandable, I
    >> checked and checkpatch didn't call this out , so its clean.
    >>
    >> Otherwise the above code looks like this
    >>
    >> if(i)
    >> return 1;
    >> return 0;
    > you should update your tree. virtpci folder has been deleted from
    > unisys driver.
    > As you are using an old tree, maybe that explains why checkpatch is not
    > giving the error.

    This is from linux-stable branch and I updated it just yesterday, so looks like the folders still there
    >
    > regards
    > sudip
    >



    \
     
     \ /
      Last update: 2015-07-01 11:01    [W:4.042 / U:0.836 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site