lkml.org 
[lkml]   [2015]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/8] regulator: pwm-regulator: Don't assign structure attributes right away
On Tue, 09 Jun 2015, Mark Brown wrote:

> On Tue, Jun 09, 2015 at 08:03:47AM +0100, Lee Jones wrote:
>
> > Admittedly this is an extreme example, but I do consider:
>
> > init_data = of_get_regulator_init_data(<blah>);
> > if (init_data)
> > return -ENOMEM;
>
> > ... neater than:
>
> > config.init_data = of_get_regulator_init_data(<blah>);
> > if (!config.init_data)
> > return -ENOMEM;
>
> Oh, I see. I pretty much see things the other way for things where the
> temporary has no other users.

I don't feel passionate enough about it to contest.

Skip this patch then. Are you okay to continue the review?

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


\
 
 \ /
  Last update: 2015-06-09 13:21    [W:0.054 / U:1.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site