Messages in this thread | | | Date | Sun, 07 Jun 2015 00:13:51 -0700 (PDT) | Subject | Re: [PATCH] wan: dscc4: use msecs_to_jiffies for conversions | From | David Miller <> |
| |
From: Nicholas Mc Guire <hofrat@osadl.org> Date: Sat, 6 Jun 2015 10:41:06 +0200
> API compliance scanning with coccinelle flagged: > ./drivers/net/wan/dscc4.c:1036:1-33: > WARNING: timeout (10) seems HZ dependent > ./drivers/net/wan/dscc4.c:554:2-34: > WARNING: timeout (10) seems HZ dependent > ./drivers/net/wan/dscc4.c:599:2-34: > WARNING: timeout (10) seems HZ dependent > > Numeric constants passed to schedule_timeout_*() make the effective > timeout HZ dependent which does not seem to be the intent here. > Fixed up by converting the constant to jiffies with msecs_to_jiffies() > > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Whoever wrote these things probably wanted whatever this amounts to when HZ=100, so that is the only valid transformation you can make to fix this up here.
Otherwise you seriously risk breaking the driver.
| |