lkml.org 
[lkml]   [2015]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] wan: dscc4: use msecs_to_jiffies for conversions
David Miller <davem@davemloft.net> :
[...]
> Whoever wrote these things probably wanted whatever this amounts
> to when HZ=100, so that is the only valid transformation you can
> make to fix this up here.

It's linux kernel illiterate style from 13 years ago but I commented
dscc4_pci_reset.

wait_ack_cec and xpr_ack are dumb busy loops that break on short integer
sign change. Hackish hint.

> Otherwise you seriously risk breaking the driver.

How seriously is hard to tell. I've never tried it at really low line
rates though.

Please apply.

Thanks.

--
Ueimor


\
 
 \ /
  Last update: 2015-06-07 11:01    [W:0.034 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site