Messages in this thread | | | Date | Sun, 7 Jun 2015 10:32:43 +0200 | From | Francois Romieu <> | Subject | Re: [PATCH] wan: dscc4: use msecs_to_jiffies for conversions |
| |
David Miller <davem@davemloft.net> : [...] > Whoever wrote these things probably wanted whatever this amounts > to when HZ=100, so that is the only valid transformation you can > make to fix this up here.
It's linux kernel illiterate style from 13 years ago but I commented dscc4_pci_reset.
wait_ack_cec and xpr_ack are dumb busy loops that break on short integer sign change. Hackish hint.
> Otherwise you seriously risk breaking the driver.
How seriously is hard to tell. I've never tried it at really low line rates though.
Please apply.
Thanks.
-- Ueimor
| |