lkml.org 
[lkml]   [2015]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 2/2] gpio_wdt: Add option for early registration
From
Date
On Sat, 2015-06-06 at 00:46 -0700, Jean-Baptiste Theou wrote:
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig

> +config GPIO_WATCHDOG_ARCH_INITCALL
> + bool "Register the watchdog as early as possible"
> + depends on GPIO_WATCHDOG=y
> + help
> + In some situations, the default initcall level (module_init)
> + in not early enough in the boot process to avoid the watchdog
> + to be triggered.
> + If you say yes here, the initcall level would be raised to
> + arch_initcall.
> + If in doubt, say N.

> --- a/drivers/watchdog/gpio_wdt.c
> +++ b/drivers/watchdog/gpio_wdt.c

> +#ifdef GPIO_WATCHDOG_ARCH_INITCALL

You meant
#ifdef CONFIG_GPIO_WATCHDOG_ARCH_INITCALL

Please use scripts/checkkconfigsymbols.py.

> +static int __init gpio_wdt_init(void)
> +{
> + return platform_driver_register(&gpio_wdt_driver);
> +}
> +arch_initcall(gpio_wdt_init);
> +#else
> module_platform_driver(gpio_wdt_driver);
> +#endif

The entire patch is basically an elaborate NOP. How did this pass your
testing?


Paul Bolle



\
 
 \ /
  Last update: 2015-06-06 12:21    [W:0.055 / U:3.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site