lkml.org 
[lkml]   [2015]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] gpio_wdt: Add option for early registration
On Sat, Jun 06, 2015 at 12:03:06PM +0200, Paul Bolle wrote:
> On Sat, 2015-06-06 at 00:46 -0700, Jean-Baptiste Theou wrote:
> > --- a/drivers/watchdog/Kconfig
> > +++ b/drivers/watchdog/Kconfig
>
> > +config GPIO_WATCHDOG_ARCH_INITCALL
> > + bool "Register the watchdog as early as possible"
> > + depends on GPIO_WATCHDOG=y
> > + help
> > + In some situations, the default initcall level (module_init)
> > + in not early enough in the boot process to avoid the watchdog
> > + to be triggered.
> > + If you say yes here, the initcall level would be raised to
> > + arch_initcall.
> > + If in doubt, say N.
>
> > --- a/drivers/watchdog/gpio_wdt.c
> > +++ b/drivers/watchdog/gpio_wdt.c
>
> > +#ifdef GPIO_WATCHDOG_ARCH_INITCALL
>
> You meant
> #ifdef CONFIG_GPIO_WATCHDOG_ARCH_INITCALL
>
> Please use scripts/checkkconfigsymbols.py.

checkkconfigsymbols.py only checks CONFIG_ prefix symbols. Since this
prefix is missing here, the script would not complain. But that's
an interesting case and worth checking for.

Kind regards,
Valentin

>
> > +static int __init gpio_wdt_init(void)
> > +{
> > + return platform_driver_register(&gpio_wdt_driver);
> > +}
> > +arch_initcall(gpio_wdt_init);
> > +#else
> > module_platform_driver(gpio_wdt_driver);
> > +#endif
>
> The entire patch is basically an elaborate NOP. How did this pass your
> testing?
>
>
> Paul Bolle


\
 
 \ /
  Last update: 2015-06-06 15:01    [W:0.036 / U:4.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site