lkml.org 
[lkml]   [2015]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] gpio_wdt: Add option for early registration
Thanks for the feedback.

I tested a version before cleanup, and the mistake was introduce during it.
It's my mistake, sorry about that. Will fix it on v4.


On Sat, 6 Jun 2015 16:11:18 +0200
Paul Bolle <pebolle@tiscali.nl> wrote:

> On Sat, 2015-06-06 at 14:56 +0200, Valentin Rothberg wrote:
> > On Sat, Jun 06, 2015 at 12:03:06PM +0200, Paul Bolle wrote:
> > > On Sat, 2015-06-06 at 00:46 -0700, Jean-Baptiste Theou wrote:
> > > > +#ifdef GPIO_WATCHDOG_ARCH_INITCALL
> > >
> > > You meant
> > > #ifdef CONFIG_GPIO_WATCHDOG_ARCH_INITCALL
> > >
> > > Please use scripts/checkkconfigsymbols.py.
> >
> > checkkconfigsymbols.py only checks CONFIG_ prefix symbols. Since this
> > prefix is missing here, the script would not complain.
>
> Of course. Thanks for correcting me.
>
> > But that's an interesting case and worth checking for.
>
> Perhaps. Depends on the amount of false positives that such checks would
> trigger, I'd say.
>
>
> Paul Bolle
>


--
Jean-Baptiste Theou <jtheou@adeneo-embedded.us>


\
 
 \ /
  Last update: 2015-06-06 18:41    [W:0.043 / U:0.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site