Messages in this thread | | | Date | Tue, 30 Jun 2015 15:36:53 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH 3/4] mremap: don't do uneccesary checks if new_len == old_len |
| |
On Sat, 20 Jun 2015, Oleg Nesterov wrote:
> The "new_len > old_len" branch in vma_to_resize() looks very confusing. > It only covers the VM_DONTEXPAND/pgoff checks but everything below is > equally unneeded if new_len == old_len. > > Change this code to return if "new_len == old_len", new_len < old_len > is not possible, otherwise the code below is wrong anyway. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: David Rientjes <rientjes@google.com>
| |