Messages in this thread | | | Date | Tue, 30 Jun 2015 15:31:19 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH 1/4] mremap: don't leak new_vma if f_op->mremap() fails |
| |
On Sat, 20 Jun 2015, Oleg Nesterov wrote:
> move_vma() can't just return if f_op->mremap() fails, we should > unmap the new vma like we do if move_page_tables() fails. To avoid > the code duplication this patch moves the "move entries back" under > the new "if (err)" branch. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Looks good! I think it was sniped by commit 4abad2ca4a4d ("mm: new arch_remap() hook") so it needs to be rebased, but after that feel free to add my
Acked-by: David Rientjes <rientjes@google.com>
| |