Messages in this thread | | | Date | Mon, 29 Jun 2015 14:46:46 +0200 | From | Eric Auger <> | Subject | Regression observed since "iommu: Propagate error in add_iommu_group" with arm-smmu |
| |
Hi Joerg, Will
I observe a regression since commit 19762d7095e6392b6ec56c363a6f29b2119488c2 (iommu: Propagate error in add_iommu_group) with arm-smmu: I am not able to bind the vfio-platform driver to one Calxeda Midway xgmac anymore. This latter is not assigned any group.
Looks like the cause is, in iommu_bus_init, when doing bus_for_each_dev(bus, NULL, &cb, add_iommu_group), add_iommu_group fails for some devices which are not upstream to smmu and enumerated before the xgmac. As a consequence bus_for_each_dev returns without looking at the xgmac.
arm_smmu_add_platform_device currently returns -ENODEV when no smmu/no master port for the device. Shouldn't we return 0 now?
Thank you in advance
Best Regards
Eric
19762d7095e6392b6ec56c363a6f29b2119488c2 is the first bad commit commit 19762d7095e6392b6ec56c363a6f29b2119488c2 Author: Joerg Roedel <jroedel@suse.de> Date: Thu May 28 18:41:26 2015 +0200
iommu: Propagate error in add_iommu_group
Make sure any errors reported from the IOMMU drivers get progapated back to the IOMMU core.
Signed-off-by: Joerg Roedel <jroedel@suse.de>
| |