Messages in this thread Patch in this message | | | Date | Mon, 22 Jun 2015 08:27:04 +0530 | From | Vaishali Thakkar <> | Subject | [PATCH v2] [SCSI] fnic: Replace memset with eth_broadcast_addr |
| |
Use eth_broadcast_addr to assign the broadcast address to the given address array instead of memset when second argument is a broadcast address 0xff.
The Coccinelle semantic patch that makes this change is as follows:
// <smpl> @eth_broadcast_addr@ identifier e; @@
-memset(e,\(0xff\|0xFF\|255\),ETH_ALEN); +eth_broadcast_addr(e); // </smpl>
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com> --- Change since v1: - Fix mistake in commit log --- drivers/scsi/fnic/fnic_scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index 155b286..650d448 100644 --- a/drivers/scsi/fnic/fnic_scsi.c +++ b/drivers/scsi/fnic/fnic_scsi.c @@ -276,7 +276,7 @@ int fnic_flogi_reg_handler(struct fnic *fnic, u32 fc_id) } if (fnic->ctlr.map_dest) { - memset(gw_mac, 0xff, ETH_ALEN); + eth_broadcast_addr(gw_mac); format = FCPIO_FLOGI_REG_DEF_DEST; } else { memcpy(gw_mac, fnic->ctlr.dest_addr, ETH_ALEN); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
| |