Messages in this thread | | | Date | Tue, 2 Jun 2015 19:27:42 -0700 | From | Guenter Roeck <> | Subject | Re: [RFC 5/9] net: dsa: mv88e6352: disable mirroring |
| |
On Tue, Jun 02, 2015 at 09:12:30PM -0400, Vivien Didelot wrote: > Hi Guenter, Andrew, > > On Jun 2, 2015, at 10:53 AM, Andrew Lunn andrew@lunn.ch wrote: > On Tue, Jun 02, 2015 at 07:16:10AM -0700, Guenter Roeck wrote: > >> On 06/01/2015 06:27 PM, Vivien Didelot wrote: > >> >Disable the mirroring policy in the monitor control register, since this > >> >feature is not needed. > >> > > >> >Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> > >> > >> Should this be a separate patch, unrelated to the patch set ? > > Indeed, this one is an unrelated patch, sorry. > > >> If I understand correctly, this effectively disables IGMP/MLD snooping. > >> I think this warrants an explanation why that it not needed, not just > >> a statement that it is not needed. > > > > +1 > > > > Especially since we might want to revisit this to implement IGMP/MLD > > snooping in the bridge. The hardware should be capable of it. > > This is something I want to disable because I can have several times > gigabit traffic on my ports. This would end up in a bottleneck on the > CPU port. Am I right? > Not really. That should not be that much traffic. Besides, IGMP/MLD snooping still needs to be enabled separately, as well as egress monitoring.
I don't think this has any impact on the traffic to the CPU port unless other configuration bits are set as well.
Guenter
| |