Messages in this thread | | | Date | Tue, 2 Jun 2015 16:53:13 +0200 | From | Andrew Lunn <> | Subject | Re: [RFC 5/9] net: dsa: mv88e6352: disable mirroring |
| |
On Tue, Jun 02, 2015 at 07:16:10AM -0700, Guenter Roeck wrote: > On 06/01/2015 06:27 PM, Vivien Didelot wrote: > >Disable the mirroring policy in the monitor control register, since this > >feature is not needed. > > > >Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> > > Should this be a separate patch, unrelated to the patch set ? > > If I understand correctly, this effectively disables IGMP/MLD snooping. > I think this warrants an explanation why that it not needed, not just > a statement that it is not needed.
+1
Especially since we might want to revisit this to implement IGMP/MLD snooping in the bridge. The hardware should be capable of it.
Andrew
| |