Messages in this thread | | | Subject | Re: [PATCH v2] drm/msm/hdmi: Use pinctrl in HDMI driver | From | "Ivan T. Ivanov" <> | Date | Tue, 02 Jun 2015 09:59:26 +0300 |
| |
Hi Stephane,
On Mon, 2015-06-01 at 16:28 -0400, Stephane Viau wrote: > Some targets (eg: msm8994) use the pinctrl framework to configure > interface pins. This change adds support for initialization and > pinctrl active/sleep state control for the HDMI driver. > > Signed-off-by: Stephane Viau <sviau@codeaurora.org> > --- > v2: > - Add devicetree binding documentation for pinctrl property [Ivan] > - Use pinctrl framework's PINCTRL_STATE_DEFAULT/SLEEP states [Ivan] >
<snip>
> > static int hdmi_bind(struct device *dev, struct device *master, void *data) > @@ -365,6 +379,7 @@ static int hdmi_bind(struct device *dev, struct device *master, void *data) > #ifdef CONFIG_OF > struct device_node *of_node = dev->of_node; > const struct of_device_id *match; > + struct pinctrl *pinctrl; > > match = of_match_node(dt_match, of_node); > if (match && match->data) { > @@ -383,6 +398,18 @@ static int hdmi_bind(struct device *dev, struct device *master, void *data) > hdmi_cfg->mux_sel_gpio = get_gpio(dev, of_node, "qcom,hdmi-tx-mux-sel"); > hdmi_cfg->mux_lpm_gpio = get_gpio(dev, of_node, "qcom,hdmi-tx-mux-lpm"); > > + /* not all targets have pinctrl, do not fail in case of error: */ > + pinctrl = devm_pinctrl_get(dev);
Probably I have to be more explicit. Why not using pins binding handled in driver really_probe()? I have to admit that I am not familiar with DRM subsystem.
Regards, Ivan
| |