Messages in this thread | | | Date | Tue, 2 Jun 2015 14:05:33 +0530 | From | Sudip Mukherjee <> | Subject | Re: [PATCH] staging: wilc1000: fix warning while printing |
| |
On Tue, Jun 02, 2015 at 10:29:17AM +0200, Konrad Zapalowicz wrote: > On 06/02, Sudip Mukherjee wrote: > > size_t should print using %zu, but here it was using %d and hence we > > were getting warning while printing. > > > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > > --- > > > > I think it will be easy to remove the other warnings if all the typedefs > > are removed first. > > > > drivers/staging/wilc1000/wilc_spi.c | 2 +- > > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++--- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c > > index d0e7610..6d854fd 100644 > > --- a/drivers/staging/wilc1000/wilc_spi.c > > +++ b/drivers/staging/wilc1000/wilc_spi.c > > @@ -404,7 +404,7 @@ static int spi_cmd_complete(uint8_t cmd, uint32_t adr, uint8_t *b, uint32_t sz, > > #undef NUM_DUMMY_BYTES > > > > if (len2 > (sizeof(wb) / sizeof(wb[0]))) { > > - PRINT_ER("[wilc spi]: spi buffer size too small (%d) (%d)\n", > > + PRINT_ER("[wilc spi]: spi buffer size too small (%d) (%lu)\n", > > Hi, it seems that the above line should use %zu too. Am I correct or I'm > missing something? oops. my mistake. %lu is correct but i missed mentioning the warning about long unsigned int in the commit message.
regards sudip
| |