lkml.org 
[lkml]   [2015]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 2/5] mm/mempool: allow NULL `pool' pointer in mempool_destroy()
On Tue, 9 Jun 2015, Sergey Senozhatsky wrote:

> mempool_destroy() does not tolerate a NULL mempool_t pointer
> argument and performs a NULL-pointer dereference. This requires
> additional attention and effort from developers/reviewers and
> forces all mempool_destroy() callers to do a NULL check
>
> if (pool)
> mempool_destroy(pool);
>
> Or, otherwise, be invalid mempool_destroy() users.
>
> Tweak mempool_destroy() and NULL-check the pointer there.
>
> Proposed by Andrew Morton.
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Reported-by: Andrew Morton <akpm@linux-foundation.org>
> LKML-reference: https://lkml.org/lkml/2015/6/8/583

Acked-by: David Rientjes <rientjes@google.com>

I like how your patch series is enabling us to remove many lines from the
source code. But doing s/Reported-by/Suggested-by/ can also make your
changelog two lines shorter ;)


\
 
 \ /
  Last update: 2015-06-18 01:41    [W:0.205 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site