lkml.org 
[lkml]   [2015]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH 1/5] mm/slab_common: allow NULL cache pointer in kmem_cache_destroy()
    On Tue, 9 Jun 2015, Sergey Senozhatsky wrote:

    > kmem_cache_destroy() does not tolerate a NULL kmem_cache pointer
    > argument and performs a NULL-pointer dereference. This requires
    > additional attention and effort from developers/reviewers and
    > forces all kmem_cache_destroy() callers (200+ as of 4.1) to do
    > a NULL check
    >
    > if (cache)
    > kmem_cache_destroy(cache);
    >
    > Or, otherwise, be invalid kmem_cache_destroy() users.
    >
    > Tweak kmem_cache_destroy() and NULL-check the pointer there.
    >
    > Proposed by Andrew Morton.
    >
    > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
    > Reported-by: Andrew Morton <akpm@linux-foundation.org>
    > LKML-reference: https://lkml.org/lkml/2015/6/8/583

    Acked-by: David Rientjes <rientjes@google.com>

    kmem_cache_destroy() isn't a fastpath, this is long overdue. Now where's
    the patch to remove the NULL checks from the callers? ;)


    \
     
     \ /
      Last update: 2015-06-18 01:41    [W:4.318 / U:0.560 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site