Messages in this thread | | | Date | Wed, 17 Jun 2015 10:36:30 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH RFC v7 2/3] crypto: rsa: add a new rsa generic implementation |
| |
On Tue, Jun 16, 2015 at 07:32:16PM -0700, Tadeusz Struk wrote: > > I thought that -EBADMSG was mainly used for authenticated ciphers in case when verification of auth data fails. > Since this are input params I thought that -EINVAL would be more appropriate. > I can change it to -EBADMSG, no problem. > Herbert, what do you think?
The existing crypto/asymmetric_key errno scheme doesn't really mesh in with the rest of crypto. So you'll just have to pick one scheme and stick with it.
I don't really mind either way as long as the error codes are unique and meaningful.
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |