Messages in this thread | | | Date | Tue, 16 Jun 2015 19:32:16 -0700 | From | Tadeusz Struk <> | Subject | Re: [PATCH RFC v7 2/3] crypto: rsa: add a new rsa generic implementation |
| |
Hi David, On 06/16/2015 03:10 PM, David Howells wrote: >> +static int _rsa_sign(const struct rsa_key *key, MPI s, MPI m) >> > +{ >> > + /* (1) Validate 0 <= m < n */ >> > + if (mpi_cmp_ui(m, 0) < 0 || mpi_cmp(m, key->n) >= 0) >> > + return -EINVAL; > Why -EINVAL not -EBADMSG?
I thought that -EBADMSG was mainly used for authenticated ciphers in case when verification of auth data fails. Since this are input params I thought that -EINVAL would be more appropriate. I can change it to -EBADMSG, no problem. Herbert, what do you think?
| |