Messages in this thread |  | | Date | Thu, 11 Jun 2015 21:30:48 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH 3/6] clocksource: bcm2835: Migrate to new 'set-state' interface |
| |
On 11-06-15, 17:25, Daniel Lezcano wrote: > Please mention in the log you removed the RESUME because it does > nothing and the core code will just ignore it.
Okay.
> The patch is ok but there is an inconsistency on how are handled the > different callbacks. tick_resume can be omitted but not > state_shutdown and state_oneshot forcing the drivers to define empty > functions.
It was done because they are thought to be compulsory, but even I am not sure if we should make all callbacks as optional.
-- viresh
|  |