[lkml]   [2015]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 3/6] clocksource: bcm2835: Migrate to new 'set-state' interface
On 06/11/2015 06:00 PM, Viresh Kumar wrote:
> On 11-06-15, 17:25, Daniel Lezcano wrote:
>> Please mention in the log you removed the RESUME because it does
>> nothing and the core code will just ignore it.
> Okay.
>> The patch is ok but there is an inconsistency on how are handled the
>> different callbacks. tick_resume can be omitted but not
>> state_shutdown and state_oneshot forcing the drivers to define empty
>> functions.
> It was done because they are thought to be compulsory, but even I
> am not sure if we should make all callbacks as optional.

Yes, I think it would make sense to ignore NULL callback in
__clockevents_set_state, otherwise we will end up to fill the different
drivers with duplicated noop functions.

<> │ Open source software for ARM SoCs

Follow Linaro: <> Facebook |
<!/linaroorg> Twitter |
<> Blog

 \ /
  Last update: 2015-06-11 18:21    [W:0.042 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site