lkml.org 
[lkml]   [2015]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: fec: add support of ethtool get_regs
From
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
Date: Sat, 9 May 2015 22:17:46 +0100

> On Sat, May 09, 2015 at 10:52:08PM +0200, Philippe Reynes wrote:
>> +static void fec_enet_get_regs(struct net_device *ndev,
>> + struct ethtool_regs *regs, void *regbuf)
>> +{
>> + struct fec_enet_private *fep = netdev_priv(ndev);
>> +
>> + memcpy_fromio(regbuf, fep->hwp, regs->len);
>
> Using memcpy_fromio() to copy device registers is not a good idea -
> it can use a variable access size which can cause bus faults.

Agreed.


\
 
 \ /
  Last update: 2015-05-09 23:41    [W:0.102 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site