Messages in this thread | | | Date | Sat, 9 May 2015 22:17:46 +0100 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH] net: fec: add support of ethtool get_regs |
| |
On Sat, May 09, 2015 at 10:52:08PM +0200, Philippe Reynes wrote: > +static void fec_enet_get_regs(struct net_device *ndev, > + struct ethtool_regs *regs, void *regbuf) > +{ > + struct fec_enet_private *fep = netdev_priv(ndev); > + > + memcpy_fromio(regbuf, fep->hwp, regs->len);
Using memcpy_fromio() to copy device registers is not a good idea - it can use a variable access size which can cause bus faults.
-- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.
| |