Messages in this thread | | | Date | Thu, 7 May 2015 07:46:29 -0700 | From | York Sun <> | Subject | Re: Why isn't IRQ shared for i2c-ocore |
| |
On 05/07/2015 12:01 AM, Lee Jones wrote: >> I have a follow up question regarding interrupt. I see many I2C bus drivers >> request interrupt with flag = 0. Why not using IRQF_SHARED? > > Probably because that particular IRQ is only used by the I2C > Controller. I'm not exactly sure that you're getting at? Why do you > think it should be shared? You should only flag it as shared if it > is.
I am working on a driver for multifunction card with open core I2C controller. The interrupt is shared between I2C and other controller.
> >> I understand the performance concern. If there is any other reason, I want to >> know about it before I go too far on my driver. > > This sort of stuff is trivial to fix and shouldn't stand in the way > of you writing and submitting v1 of your driver. >
It is trivial to fix. I just want to know if there is any reason the interrupt wasn't shared. Seems not.
York
| |