lkml.org 
[lkml]   [2015]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] net: usb: allow MTU that is a multiple of USB packet size
Date
Current usbnet driver rejects setting MTU that is a multiple
of USB endpoint's wMaxPacketSize size. However, it may only
lead to possible performance degradation but is not so
critical that its using should be prohibited. So allow it
but also warn user about possible issue.

Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
---
drivers/net/usb/usbnet.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 733f4fe..09dc848 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -382,9 +382,11 @@ int usbnet_change_mtu (struct net_device *net, int new_mtu)

if (new_mtu <= 0)
return -EINVAL;
- // no second zero-length packet read wanted after mtu-sized packets
+ /* warn about second zero-length packet read after mtu-sized packets */
if ((ll_mtu % dev->maxpacket) == 0)
- return -EDOM;
+ netdev_warn(dev->net, "MTU %d is a multiple of USB wMaxPacketSize (%d),"
+ " consider possible performance degradation\n",
+ ll_mtu, dev->maxpacket);
net->mtu = new_mtu;

dev->hard_mtu = net->mtu + net->hard_header_len;
--
1.7.9.5


\
 
 \ /
  Last update: 2015-05-07 12:21    [W:0.044 / U:1.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site