Messages in this thread | | | Subject | Re: [PATCH 2/2] x86/quark: Add Quark embedded SRAM self-test | From | Paul Bolle <> | Date | Tue, 05 May 2015 10:34:39 +0200 |
| |
On Mon, 2015-05-04 at 03:17 +0100, Bryan O'Donoghue wrote: > --- a/arch/x86/Kconfig.debug > +++ b/arch/x86/Kconfig.debug
> +config DEBUG_ESRAM_SELFTEST > + bool "Embedded SRAM self test" > + default n > + depends on INTEL_ESRAM > + ---help--- > + This option enables automated sanity testing of the eSRAM driver > + on Quark X1000. A simple set of tests with performance metrics > + measured a DRAM baseline are run. These tests show the measured > + performance increase across a given memory size for a series of > + incrementing read sizes. > + > + If unsure say N here.
> --- a/arch/x86/platform/intel-quark/Makefile > +++ b/arch/x86/platform/intel-quark/Makefile
> +obj-$(CONFIG_DEBUG_ESRAM_SELFTEST) += esram_selftest.o
DEBUG_ESRAM_SELFTEST is a bool Kconfig symbol. So esram_selftest.o will never be part of a module, right?
> --- /dev/null > +++ b/arch/x86/platform/intel-quark/esram_selftest.c
> + * IMR self test. The purpose of this module is to run a set of tests on the > + * IMR API to validate it's sanity. We check for overlapping, reserved > + * addresses and setup/teardown sanity.
> +MODULE_DEVICE_TABLE(x86cpu, esram_ids);
> +module_init(esram_self_test_init); > +module_exit(esram_self_test_exit); > + > +MODULE_AUTHOR("Bryan O'Donoghue <pure.logic@nexus-software.ie>"); > +MODULE_DESCRIPTION("Intel Quark eSRAM self-test driver"); > +MODULE_LICENSE("Dual BSD/GPL");
There's some module specific boilerplate above. (Note that I'm not sure whether KBUILD_MODNAME is module specific, sorry.) And the comment talks about a module too.
Was your intention to make DEBUG_ESRAM_SELFTEST a tristate symbol?
Thanks,
Paul Bolle
| |