lkml.org 
[lkml]   [2015]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] x86/quark: Add Quark embedded SRAM support
    On 05/04/2015 08:00 AM, Thomas Gleixner wrote:
    >
    >> + */
    >> +static int esram_dbgfs_state_show(struct seq_file *s, void *unused)
    >> +{
    >> + struct esram_dev *edev = &esram_dev;
    >> + u32 data;
    >> + u32 reg = (u32)s->private;
    >
    > You really like to waste lines. What's wrong with:
    >
    > u32 data, reg = .....
    >

    I have to say I agree with Bryan here: it is rather ugly to mix
    uninitialized and initialized variables on the same declaration line.

    -hpa




    \
     
     \ /
      Last update: 2015-05-06 01:01    [W:4.101 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site