Messages in this thread | | | Date | Tue, 05 May 2015 15:19:25 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 1/2] x86/quark: Add Quark embedded SRAM support |
| |
On 05/04/2015 08:00 AM, Thomas Gleixner wrote: > >> + */ >> +static int esram_dbgfs_state_show(struct seq_file *s, void *unused) >> +{ >> + struct esram_dev *edev = &esram_dev; >> + u32 data; >> + u32 reg = (u32)s->private; > > You really like to waste lines. What's wrong with: > > u32 data, reg = ..... >
I have to say I agree with Bryan here: it is rather ugly to mix uninitialized and initialized variables on the same declaration line.
-hpa
| |