Messages in this thread | | | Date | Tue, 5 May 2015 17:16:46 -0500 | From | Bjorn Helgaas <> | Subject | Re: [PATCH v3 3/5] PCI: st: Provide support for the sti PCIe controller |
| |
On Fri, Apr 10, 2015 at 11:12:46AM +0200, Gabriel FERNANDEZ wrote: > sti pcie is built around a Synopsis Designware PCIe IP. > > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> > Signed-off-by: Gabriel Fernandez <gabriel.fernandez@linaro.org>
> +/* ST PCIe driver does not allow module unload */
Is there something that prevents module unload, or is it just untested?
> +static int __init pcie_init(void) > +{ > + return platform_driver_probe(&st_pcie_driver, st_pcie_probe); > +} > +device_initcall(pcie_init);
Can you use module_platform_driver_probe() or module_init() here?
> +MODULE_AUTHOR("Fabrice Gasnier <fabrice.gasnier@st.com>"); > +MODULE_DESCRIPTION("PCI express Driver for ST SoCs"); > +MODULE_LICENSE("GPL v2"); > -- > 1.9.1 >
| |