lkml.org 
[lkml]   [2015]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next 1/1] hv_netvsc: Properly size the vrss queues
Since you're redoing this anyway.

On Tue, May 26, 2015 at 04:21:09PM -0700, K. Y. Srinivasan wrote:
> diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h
> index ddcc7f8..dd45440 100644
> --- a/drivers/net/hyperv/hyperv_net.h
> +++ b/drivers/net/hyperv/hyperv_net.h
> @@ -161,6 +161,7 @@ struct netvsc_device_info {
> unsigned char mac_adr[ETH_ALEN];
> bool link_state; /* 0 - link up, 1 - link down */
> int ring_size;
> + u32 max_num_vrss_chns;

We (Joe and I) have commented before that long names don't mix well with
the 80 character limit. You could just leave the "num_" out. Almost
all variables are numbers in C so it doesn't add anything.

regards,
dan carpenter


\
 
 \ /
  Last update: 2015-05-28 09:21    [W:0.056 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site