Messages in this thread Patch in this message | | | From | Nicholas Mc Guire <> | Subject | [PATCH] staging: rts5208: pass timeout as HZ independent value | Date | Wed, 27 May 2015 18:02:38 +0200 |
| |
schedule_timeout takes a timeout in jiffies but the code currently is passing in a constant POLLING_INTERVAL which makes this timeout HZ dependent, so pass it through msecs_to_jiffies() to fix this up.
patch was compile tested for x86_64_defconfig + CONFIG_STAGING=y, CONFIG_RTS5208=m
Patch is against 4.0-rc5 (localversion-next is -next-20150527)
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> ---
As there is no documentation of the intended timeout it might be wrong to convert it with msecs_to_jiffies - so someone that knows this driver needs to check on the actual value - but in any case it needs to be passed in a HZ independent way.
drivers/staging/rts5208/rtsx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c index d64b6ed..1bcadba 100644 --- a/drivers/staging/rts5208/rtsx.c +++ b/drivers/staging/rts5208/rtsx.c @@ -537,7 +537,7 @@ static int rtsx_polling_thread(void *__dev) for (;;) { set_current_state(TASK_INTERRUPTIBLE); - schedule_timeout(POLLING_INTERVAL); + schedule_timeout(msecs_to_jiffies(POLLING_INTERVAL)); /* lock the device pointers */ mutex_lock(&(dev->dev_mutex)); -- 1.7.10.4
| |