lkml.org 
[lkml]   [2015]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v8 2/4] sched: Rewrite runnable load and utilization average tracking
On 25 May 2015 at 03:49, Yuyang Du <yuyang.du@intel.com> wrote:
[snip]

>
> @@ -2585,334 +2583,156 @@ static __always_inline int __update_entity_runnable_avg(u64 now, int cpu,
> periods = delta / 1024;
> delta %= 1024;
>
> - sa->runnable_avg_sum = decay_load(sa->runnable_avg_sum,
> - periods + 1);
> - sa->running_avg_sum = decay_load(sa->running_avg_sum,
> - periods + 1);
> - sa->avg_period = decay_load(sa->avg_period,
> - periods + 1);
> + sa->load_sum = decay_load(sa->load_sum, periods + 1);
> + sa->util_sum = decay_load(u64(sa->util_sum), periods + 1);

Hi Yuyang,

Brackets are missing around u64 to cast util_sum


>
> /* Efficiently calculate \sum (1..n_period) 1024*y^i */
> - runnable_contrib = __compute_runnable_contrib(periods);
> - if (runnable)
> - sa->runnable_avg_sum += runnable_contrib;
> + contrib = __compute_runnable_contrib(periods);
> + if (weight)

>


\
 
 \ /
  Last update: 2015-05-26 18:21    [W:0.043 / U:1.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site