Messages in this thread | | | Date | Sat, 23 May 2015 19:55:46 +0200 | From | Sebastian Reichel <> | Subject | Re: [PATCH 7/7] drivers/power: Convert non-modular syscon-reboot to use builtin_driver_register |
| |
Hi,
On Sun, May 10, 2015 at 03:49:45PM -0400, Paul Gortmaker wrote: > This file depends on Kconfig options all of which are a bool, so > we use the appropriate registration function, which avoids us > relying on an implicit inclusion of <module.h> which we are > doing currently. > > While this currently works, we really don't want to be including > the module.h header in non-modular code, which we'd be forced > to do, pending some upcoming code relocation from init.h into > module.h. So we fix it now by using the non-modular equivalent. > > Cc: Sebastian Reichel <sre@kernel.org> > Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> > Cc: David Woodhouse <dwmw2@infradead.org> > Cc: linux-pm@vger.kernel.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > --- > drivers/power/reset/syscon-reboot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/reset/syscon-reboot.c b/drivers/power/reset/syscon-reboot.c > index d3c7d245ae63..7d0d269a0837 100644 > --- a/drivers/power/reset/syscon-reboot.c > +++ b/drivers/power/reset/syscon-reboot.c > @@ -88,4 +88,4 @@ static struct platform_driver syscon_reboot_driver = { > .of_match_table = syscon_reboot_of_match, > }, > }; > -module_platform_driver(syscon_reboot_driver); > +builtin_platform_driver(syscon_reboot_driver);
Acked-By: Sebastian Reichel <sre@kernel.org>
-- Sebastian [unhandled content-type:application/pgp-signature] | |