lkml.org 
[lkml]   [2015]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/7] platform_device: better support builtin boilerplate avoidance
From
On Thu, May 28, 2015 at 2:50 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> [Re: [PATCH 1/7] platform_device: better support builtin boilerplate avoidance] On 12/05/2015 (Tue 13:46) Linus Walleij wrote:
>
>> This does not inhibit probe() and remove() to be
>> triggered from sysfs does it?
>>
>> What is needed on builtin drivers is to set
>> .suppress_bind_attrs = true on the struct device_driver
>> so that we inhibit the creation of sysfs files to probe
>> and remove the driver by operator intervention.
>
> Is this needed? I think we will break existing use cases if we do this.
>
> For example, I have IGB as built-in, but I can still unbind one of the
> four devices and make it available for PCI pass through to KVM with:
>
> echo "0000:0a:00.1" > /sys/bus/pci/drivers/igb/unbind
> echo "0000:0a:00.1" > /sys/bus/pci/drivers/pci-stub/bind

Aha PCI device which noone else is dependent on, I guess
it's true.

I think we have a problem as to what "builtin" really means.
For example if this is a builtin regulator, clock, GPIO, DMA etc
driver, we want to suppress the binding/unbinding from userspace
too, since these drivers provide resources to others and
if you unbind them, nasty things happen. Unbinding/rebinding
is fine as long as noone else depend on you. However for
a large number of builtins, that is the case :P

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2015-06-02 12:01    [W:0.098 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site