Messages in this thread | | | Date | Fri, 22 May 2015 14:40:48 -0700 | Subject | Re: KVM: x86: zero kvmclock_offset when vcpu0 initializes kvmclock system MSR | From | Owen Hofmann <> |
| |
Change as described sounds good, however:
> @@ -2188,6 +2188,8 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, > struct msr_data *msr_info) > &vcpu->requests); > > ka->boot_vcpu_runs_old_kvmclock = tmp; > + > + ka->kvmclock_offset = get_kernel_ns(); > }
Should this be ka->kvmclock_offset = -get_kernel_ns()? kvm_guest_time_update() sets hv_clock.system_time = kernel_ns + v->kvm->arch.kvmclock_offset, and similarly kvmclock_offset is added to the value from get_kernel_ns() in the handler for HV_X64_MSR_TIME_REF_COUNT.
| |