lkml.org 
[lkml]   [2015]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] livepatch: Let compiler put module initialized function to section ".init.text"
On 05/22/15 at 08:25P, Josh Poimboeuf wrote:
> On Fri, May 22, 2015 at 02:10:32PM +0800, Minfei Huang wrote:
> > From: Minfei Huang <mnfhuang@gmail.com>
> >
> > Usually we prefer to let compiler put the module initialized function to
> > section ".init.text". Thus this text in memory will be freed in future.
> >
> > Once we add the "__init" preceding function name, we can use following
> > command to find it in specfied section.
> >
> > $ objdump -t -j .init.text built-in.o
> >
> > built-in.o: file format elf64-x86-64
> >
> > SYMBOL TABLE:
> > 0000000000000000 l d .init.text 0000000000000000 .init.text
> > 0000000000000000 l F .init.text 000000000000004e klp_init
> >
> > Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
>
> The patch looks good but can you make the subject more concise? Maybe
> something like:
>
> livepatch: annotate klp_init() with __init

Sure. Will modify the subject.

Thanks
Minfei

>
> Thanks.
>
> --
> Josh


\
 
 \ /
  Last update: 2015-05-22 16:21    [W:0.225 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site