Messages in this thread | | | Date | Fri, 22 May 2015 08:25:28 -0500 | From | Josh Poimboeuf <> | Subject | Re: [PATCH] livepatch: Let compiler put module initialized function to section ".init.text" |
| |
On Fri, May 22, 2015 at 02:10:32PM +0800, Minfei Huang wrote: > From: Minfei Huang <mnfhuang@gmail.com> > > Usually we prefer to let compiler put the module initialized function to > section ".init.text". Thus this text in memory will be freed in future. > > Once we add the "__init" preceding function name, we can use following > command to find it in specfied section. > > $ objdump -t -j .init.text built-in.o > > built-in.o: file format elf64-x86-64 > > SYMBOL TABLE: > 0000000000000000 l d .init.text 0000000000000000 .init.text > 0000000000000000 l F .init.text 000000000000004e klp_init > > Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
The patch looks good but can you make the subject more concise? Maybe something like:
livepatch: annotate klp_init() with __init
Thanks.
-- Josh
| |