lkml.org 
[lkml]   [2015]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] spmi: add command tracepoints for SPMI
On Wed, 20 May 2015 11:29:55 -0700
Stephen Boyd <sboyd@codeaurora.org> wrote:


> > I see no reason to spend to 4-8 bytes when spmi spec allows for maximum
> > buffer size of 16. Do you suggest changing the API of read_cmd()?
> > >
>
> Is that a maximum buffer size of 16 bytes? I'd prefer consistency
> with the API that's being traced, that's all. Changing it to u8
> to save a few bytes probably doesn't make any difference if the
> architecture passes function arguments in CPU registers which are
> 32 or 64 bits wide or if the function can be inlined enough by
> the compiler to where the len parameter is kept in a register.
>


I believe the worry is about wasting bytes in the ring buffer if not
necessary. But we do that in other tracepoints, so it's really up to
the maintainer.

-- Steve


\
 
 \ /
  Last update: 2015-05-20 21:21    [W:0.059 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site