Messages in this thread | | | Date | Wed, 20 May 2015 10:59:23 -0700 | From | Bin Gao <> | Subject | Re: [PATCH v3 1/2] serial_core: add pci uart early console support |
| |
On Wed, May 20, 2015 at 11:16:25AM +0200, Paul Bolle wrote: > What I should have asked is: do you expect architectures other than X86 > to set HAVE_EARLY_PCI? Because then you should put that Kconfig entry in > a file reachable by all architectures. Say, in init/Kconfig or in > drivers/tty/serial/Kconfig. > > (You can also have an entry for HAVE_EARLY_PCI for each arch that needs > it, but that would be a bit silly.) >
The HAVE_EARLY_PCI entry should be actually in generic PCI layer, i.e. drivers/pci, because it's a PCI feature but only some archs (currently only x86) support it. Then an arch with this feature could announce it in arch/<arch>/Kconfig by: select HAVE_EARLY_PCI if PCI
| |